Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: modify the wrong Chinese word #1922

Merged
merged 2 commits into from
Jul 22, 2022
Merged

docs: modify the wrong Chinese word #1922

merged 2 commits into from
Jul 22, 2022

Conversation

whyer11
Copy link
Contributor

@whyer11 whyer11 commented Nov 3, 2021

"阀值" is a wrong word in Chinese, "阈值" should be used here

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: documents

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

"阀值" is a wrong word in Chinese, "阈值" should be used here
@whyer11
Copy link
Contributor Author

whyer11 commented Nov 3, 2021

why checks all run failed?

image

@lmiller1990
Copy link
Member

I guess we need to update the Netlify infrastructure. I have no idea how to do this, I will find out. Maybe @afontcu has some context 🤔 ?

@whyer11
Copy link
Contributor Author

whyer11 commented Nov 16, 2021

any update?

@lmiller1990
Copy link
Member

I do not have access to the Netlify account to update the image, but I asked someone who does. Should be able to get this fixed this week.

@lmiller1990
Copy link
Member

Still no luck. I miss GH pages, it was a lot easier that having to manage access to multiple tools. Maybe we should move back to that.

@lmiller1990
Copy link
Member

Gonna merge this while I try to chase up a Netlify fix.

@lmiller1990 lmiller1990 merged commit a9dace1 into vuejs:dev Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants