fix(router): prevent memory leaks by removing app references from $router.apps once app destroyed (Fixes #2639) #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes vuejs#2639) Prevent destroyed apps from causing memory leak in `$router.apps` array. Fixes vuejs#2639
posva
requested changes
Mar 5, 2019
Prevents history listeners from being set up multiple times
merge dev into patch
|
@posva I have added test suites, and handled situation where the main (initial) app is destroyed. |
|
Just wondering if there should be additional test(s) for a nested router (i.e. a second |
|
What do you mean by nested router? |
|
@posva I see in the e2e tests there are tests for nested routers (a router within a router): https://github.com/vuejs/vue-router/blob/dev/test/e2e/specs/nested-router.js https://github.com/vuejs/vue-router/tree/dev/examples/nested-router Although the multiple routers share the same Router class instance, so probably additional testing isn't necessary. |
|
Closing in favor of #2706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent memory leaks by removing app(s) from
$router.appsarray once app has been destroyed.Fixes #2639