Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jest template: fix the name of the tested file #775

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Jest template: fix the name of the tested file #775

merged 2 commits into from
Feb 6, 2018

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Feb 4, 2018

Replace Hello.vue by HelloWorld.vue

@dunglas dunglas mentioned this pull request Feb 4, 2018
Closed
@posva
Copy link
Member

posva commented Feb 4, 2018

I think you did the same PR twice 😄

@dunglas
Copy link
Contributor Author

dunglas commented Feb 4, 2018

Almost, I noticed later that there is the same "problem" for the Mocha template.

@posva
Copy link
Member

posva commented Feb 4, 2018

I mean it appears to be the exact same change on the same file (mocha plugin)

@yyx990803
Copy link
Member

This PR is changing the mocha plugin :)

I think you can just change both plugins in the same PR.

@dunglas
Copy link
Contributor Author

dunglas commented Feb 5, 2018

Done

@yyx990803 yyx990803 merged commit 1902d9c into vuejs:dev Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunglas @posva @yyx990803