fix(cli-plugin-eslint): make eslint deps optional #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. In @vue/cli-plugin-eslint 3.1.0+, eslint will be explicitly added to the project's package.json, so it is **optional**. 2. `optionalDependencies` will still be installed by npm by default, just no longer cause installation to fail when error happens. 3. ESLint v4 did cause weird errors sometimes, like `npm WARN ajv-keywords@2.1.1 requires a peer of ajv@^5.0.0 but none is installed.` Though this warning never caused any errors on my machine, I think it's good to make the plugin fail-safe.
3c446db to
9b3cfcf
Compare
|
This should also fix #2567 (comment) |
|
Note: This may break use cases like this if their projects were created by @vue/cli v3.0.x: #1242 (comment) Edit: according to #1242 (comment) so this feature never works correctly before, so I think it's safe to break it. |
|
Any updates on this? 🙂 |
|
This update will break the projects were created by @vue/cli v3.0.x
|
|
@one-pieces Did you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the project's package.json, so it is optional.
optionalDependencieswill still be installed by npm by default,just no longer cause installation to fail when error happens.
npm WARN ajv-keywords@2.1.1 requires a peer of ajv@^5.0.0 but none is installed.Though this warning never caused any errors on my machine, I think it's
good to make the plugin fail-safe.
This change fixes #3009