Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preset): plugin invoke order don't sort by unicode order #2656

Merged
merged 1 commit into from
Oct 9, 2018
Merged

fix(preset): plugin invoke order don't sort by unicode order #2656

merged 1 commit into from
Oct 9, 2018

Conversation

AmyFoxFN
Copy link
Contributor

@AmyFoxFN AmyFoxFN commented Sep 29, 2018

Hi,

Thanks for the new cli, it's really easy to use!

However, this days, when I update to v3.0.4. There is a problem of the invoke order of my preset plugins.

For example, here is the plugins config of preset.json:

{
    "plugins": {
        "@vue/cli-plugin-babel": {},
        "@dd/vue-cli-plugin-need-modify-based-babel": {
            "prompts": true
        }
    }
}

I need to invoke the @dd/vue-cli-plugin-need-modify-based-babel behind the @vue/cli-plugin-babel. But the sortObject function in v3.0.4 would change my intended order to the sort of Unicode code point value. And I think do not sort by unicode is more appropriate for preset.plugin.

@AmyFoxFN
Copy link
Contributor Author

AmyFoxFN commented Oct 9, 2018

Is there anyone could help to handle this fix PR? @sodatea

@dolymood
Copy link

dolymood commented Oct 9, 2018

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants