Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(invoke): issue #1037 invoke binary files #1038

Merged
merged 1 commit into from
Mar 27, 2018
Merged

fix(invoke): issue #1037 invoke binary files #1038

merged 1 commit into from
Mar 27, 2018

Conversation

elevatebart
Copy link
Contributor

Using vue invoke was breaking all binary files because of encoding issues
issue #1037

@elevatebart
fix(invoke): issue #1037 invoke binary files
117bdee 
Using `vue invoke` was breaking all binary files because of encoding issues
@elevatebart elevatebart mentioned this pull request Mar 27, 2018
Closed
@yyx990803
Copy link
Member

Hey thanks for the PR! Can you please remove the prettier stylistic changes?

@yyx990803
Copy link
Member

Nvm, I'll take those changes ;)

@yyx990803 yyx990803 merged commit e65110f into vuejs:dev Mar 27, 2018
@elevatebart
Copy link
Contributor Author

Should be a .prettierrc file in the repo?
=> 120chars + singleQuotes.
I believe that is what happened to me and might happen to ther people that have prettier installed.
If you agree, I'll cook up another PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elevatebart @yyx990803