Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vue School summer banner #1457

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Update Vue School summer banner #1457

merged 1 commit into from
Jul 25, 2022

Conversation

nicodevs
Copy link
Contributor

@nicodevs nicodevs commented Jul 18, 2022

This PR updates the banner introduced by #1407

The banner at the top of https://pinia.vuejs.org/ informs users about Vue School’s Summer Sale promotion.

The banner is closable and opens Vue School's Summer Sale promo page in a new tab. The banner will not reappear if a user has closed it (stored in localStorage).

Please note that this banner includes a countdown. The component uses @chenfengyuan/vue-countdown.

Click here to see screenshots of the banner

@netlify
Copy link

netlify bot commented Jul 18, 2022

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit 746d59f
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/62deb2967d4d830008b541d1
😎 Deploy Preview https://deploy-preview-1457--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2022

Codecov Report

Merging #1457 (1102bf8) into v2 (6be93f2) will not change coverage.
The diff coverage is n/a.

❗ Current head 1102bf8 differs from pull request most recent head 746d59f. Consider uploading reports for the commit 746d59f to get more accurate results

@@           Coverage Diff           @@
##               v2    #1457   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files           9        9           
  Lines         416      416           
  Branches      109      109           
=======================================
  Hits          406      406           
  Misses          5        5           
  Partials        5        5           
Impacted Files Coverage Δ
packages/pinia/src/types.ts 100.00% <ø> (ø)
packages/testing/src/testing.ts 92.59% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@nicodevs nicodevs marked this pull request as ready for review July 25, 2022 15:13
@posva posva merged commit 1a39d4f into vuejs:v2 Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants