Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-core): nullable modelvalues #4648

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

davidmatter
Copy link
Collaborator

Closes #4646

@davidmatter davidmatter changed the title fix(language-core): nullable modelvalues wip: fix(language-core): nullable modelvalues Aug 5, 2024
@davidmatter davidmatter marked this pull request as draft August 5, 2024 14:13
@davidmatter davidmatter marked this pull request as ready for review August 5, 2024 14:22
@davidmatter davidmatter changed the title wip: fix(language-core): nullable modelvalues fix(language-core): nullable modelvalues Aug 5, 2024
@johnsoncodehk
Copy link
Member

Thanks!

@johnsoncodehk johnsoncodehk merged commit eef948d into vuejs:master Aug 9, 2024
3 checks passed
@valh1996
Copy link

valh1996 commented Dec 9, 2024

Hi @johnsoncodehk @davidmatter
Sorry to ping you, I'm using nuxt/ui where modeValue are nullable as suggested by this PR, but I get the following error:

Cannot assign type 'string | null' to type 'string | number | undefined'.
Cannot assign type 'null' to type 'string | number | undefined'

Could this bug persist? Null should be included in the type definition


VScode version : 1.95.3
Vue Official extension : 2.1.10
Vue version : ^3.5.13
Typescript version : ^5.6.3

@davidmatter
Copy link
Collaborator Author

@valh1996 to improve visibility, would you please create a new issue and link to this PR?

@valh1996 valh1996 mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v-model with arguments and defineModel does not work for nullable types since 2.0.28
3 participants