Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(vscode): add grammar test #3861

Merged
merged 7 commits into from
Aug 25, 2024
Merged

Conversation

so1ve
Copy link
Member

@so1ve so1ve commented Jan 18, 2024

resolves #3840

I'll create a new library later and use vitest for snapshot.

@so1ve so1ve marked this pull request as draft January 20, 2024 06:27
@johnsoncodehk
Copy link
Member

Could we also have a test for #3891?

@so1ve
Copy link
Member Author

so1ve commented Mar 1, 2024

Sure, I'll add it later. I need to handle newlines first :(

@so1ve
Copy link
Member Author

so1ve commented Mar 1, 2024

The tests are failing but I don't know why.

Could we also have a test for #3891?

I tried to, but it seemed to only occur when using language-tools and angular language service together.

Copy link

pkg-pr-new bot commented Aug 25, 2024

commit: 7ea9f09

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@3861

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@3861

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@3861

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@3861

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@3861

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@3861

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@3861

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@3861

Open in Stackblitz

@johnsoncodehk johnsoncodehk marked this pull request as ready for review August 25, 2024 12:45
@johnsoncodehk johnsoncodehk changed the title test: add grammar test test(vscode): add grammar test Aug 25, 2024
@johnsoncodehk johnsoncodehk merged commit a243f94 into vuejs:master Aug 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use vscode-tmlanguage-snapshot to test syntax highlighting
2 participants