fix(server-renderer): should work with css vars #6952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edison1105
reviewed
Oct 26, 2022
| @@ -285,7 +285,11 @@ function doWatch( | |||
| // we will also not call the invalidate callback (+ runner is not set up) | |||
| onCleanup = NOOP | |||
| if (!cb) { | |||
| getter() | |||
| if (flush === 'post') { | |||
There was a problem hiding this comment.
This's not the proper fix.
In SSR there is no need to setup an effect.
There was a problem hiding this comment.
Thanks, then i close it. Looking forward to your solution.
There was a problem hiding this comment.
useCssVars only work at runtime.
I believe we should not inject useCssVar() at the server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6926.
watchPostEffectis used in theuseCssVarsso that the effect can execute asynchronously.But the effect will execute immediately when using
watchPostEffectin the ssr.Maybe the PR can fix that.