fix(shared): toDisplayString toString override support

[lidlanca]

fix: #4334

fix for the case object without toString for example:

let obj = Object.create(null)  // typeof  is Object, however it will not have toString in prototype chain

handle the case that toString is non invokable, and use the JSON formatter for that case

let obj = {a:1, toString: 'bar')

improving on: #4335

[posva]

Could you leave the reviews on the other PR instead of creating a new one, please?

[lidlanca]

@edison1105 made a great pr, I worked on a fix before I saw your pr, and I hope that my PR did not offend you.
and since it was an additive pr, I kept it open for proper consideration.

@posva I would have appreciated you actually providing a review on this pr instead of closing it.
a lot of time and effort was put into this pr, and dismissing it is quite discouraging

[edison1105]

@edison1105 made a great pr, I worked on a fix before I saw your pr, and I hope that my PR did not offend you.

and since it was an additive pr, I kept it open for proper consideration.

@posva I would have appreciated you actually providing a review on this pr instead of closing it.

a lot of time and effort was put into this pr, and dismissing it is quite discouraging

It’s ok. This PR covers more cases. Actually, I don't know if it's worth to check the override toString. Like @posva commented on other PR. The point is: should we put toDisplayString farther？let’s discuss it on other PR.

[posva]

@posva I would have appreciated you actually providing a review on this pr instead of closing it.
a lot of time and effort was put into this pr, and dismissing it is quite discouraging

Once again, this is nothing personal, it's about respecting the original author's PR and making it easier to review for the maintainers as well (1 PR instead of 2 PRs) as well as discussing changes. You also seem to only see the things from your perspective, please also consider other people's perspectives 🙂

In this specific scenario, @edison1105's PR seems to be closer to what needs to be covered.

[lidlanca]

haha "nothing personal", is like saying "I don't mean to offend but".
I recommend you let someone else review my contribution so you get more unbiased perspectives. :)

I actually do hope its personal, and that other people are not treated the same way.
who knows how many valid contributions were closed or dismissed because of demand for respect, lack of proper communication or other non professional reasons.

that is my perspective.

[yyx990803]

I incorporated the isFunction check into #4335 and merged the test case from this PR. Thanks for the effort put into it!