fix(runtime-core): handle dynamic children for fragment #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfin
commented
May 10, 2020
underfin
commented
May 10, 2020
| @@ -215,7 +214,7 @@ export function createBlock( | |||
| true /* isBlock: prevent a block from tracking itself */ | |||
| ) | |||
| // save current block children on the block vnode | |||
| vnode.dynamicChildren = currentBlock || EMPTY_ARR | |||
| vnode.dynamicChildren = currentBlock | |||
There was a problem hiding this comment.
The current block is Array for stable fragment .
The current block is null (openBlock(true)) for unkeyed or keyed fragment.
So only check dynamicChildren if it is null when patch or unmount.
|
See 5b8883a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nt in block fragment
fix #1153
the reason with bug: the dynamic children is [] when unmount fragment.