Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: find parent component when only secondary component used in demo #1680

Merged
merged 2 commits into from
Feb 7, 2020

Conversation

Amour1688
Copy link
Member

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Import Primary component when only secondary component used in demo

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@netlify
Copy link

netlify bot commented Jan 1, 2020

Deploy preview for ant-desing-vue processing.

Building with commit cbef1af

https://app.netlify.com/sites/ant-desing-vue/deploys/5e3d014d64d9e2000ae6d563

@codecov
Copy link

codecov bot commented Jan 1, 2020

Codecov Report

Merging #1680 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1680   +/-   ##
=======================================
  Coverage   88.06%   88.06%           
=======================================
  Files         157      157           
  Lines        5422     5422           
  Branches     1525     1525           
=======================================
  Hits         4775     4775           
  Misses        578      578           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae50539...cbef1af. Read the comment docs.

@tangjinzhou
Copy link
Member

没看到这个pr,就直接merge master,并且做了改动 😓 要不你再master上在提交一个pr ?

@Amour1688 Amour1688 changed the base branch from config-update to master January 15, 2020 13:28
@Amour1688
Copy link
Member Author

没看到这个pr,就直接merge master,并且做了改动 😓 要不你再master上在提交一个pr ?

改到master上了

@tangjinzhou
Copy link
Member

有冲突

@Amour1688 Amour1688 force-pushed the feature/config-update branch from 755fe36 to 2f77557 Compare February 7, 2020 03:52
@Amour1688 Amour1688 changed the title perf: only secondary component used in demo perf: find parent component when only secondary component used in demo Feb 7, 2020
@Amour1688 Amour1688 force-pushed the feature/config-update branch from 2f77557 to cbef1af Compare February 7, 2020 06:18
@tangjinzhou tangjinzhou merged commit c8cc30b into vueComponent:master Feb 7, 2020
@Amour1688 Amour1688 deleted the feature/config-update branch March 24, 2020 05:08
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants