Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [TreeSelect] type check failed when value is number #1551

Merged
merged 2 commits into from
Jan 15, 2020
Merged

fix: [TreeSelect] type check failed when value is number #1551

merged 2 commits into from
Jan 15, 2020

Conversation

wensonsmith
Copy link
Contributor

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.

When value is number TreeSelect component will report type check failed warning . It should same as select.

  1. Resolve what problem.
  2. Related issue link.

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@netlify
Copy link

netlify bot commented Dec 13, 2019

Deploy preview for ant-desing-vue processing.

Building with commit 67b0915

https://app.netlify.com/sites/ant-desing-vue/deploys/5df334d43d1db2000cf6482a

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #1551 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1551   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files         157      157           
  Lines        5407     5407           
  Branches     1523     1523           
=======================================
  Hits         4760     4760           
  Misses        578      578           
  Partials       69       69
Impacted Files Coverage Δ
components/tree-select/interface.jsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c835bb8...67b0915. Read the comment docs.

@wensonsmith
Copy link
Contributor Author

Any questions about merging ?

Waiting for the merger and release . My console has too many warnings .

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2021
@wensonsmith wensonsmith deleted the patch-1 branch January 15, 2021 06:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants