Ssh cleanup #7

vthiebaut10 · 2021-10-26T21:43:56Z

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

…ult cred location for config

src/ssh/azext_ssh/_params.py

src/ssh/azext_ssh/custom.py

src/ssh/azext_ssh/ssh_utils.py

bagajjal

.

src/ssh/HISTORY.md

src/ssh/azext_ssh/_params.py

src/ssh/azext_ssh/custom.py

bagajjal · 2021-11-02T22:25:28Z

src/ssh/azext_ssh/custom.py

+            if not os.path.isdir(credentials_folder):
+                os.makedirs(credentials_folder)
+        public_key_file = os.path.join(credentials_folder, "id_rsa.pub")
+        private_key_file = os.path.join(credentials_folder, "id_rsa")
        ssh_utils.create_ssh_keyfile(private_key_file)


What happens if the id_rsa, id_rsa.pub already exists in the credentials_folder?

src/ssh/setup.py

bagajjal

.

bagajjal

.

src/ssh/azext_ssh/custom.py

src/ssh/azext_ssh/ssh_utils.py

…er to avoid linter error

…i-extensions into ssh-cleanup

Add support for connecting to local user on target machine

* build: add cicd pipeline (#7) * build: move update version logic to workflow (#8) * build: Run CI on multiple python version (Azure#38) * build: Run CI in Python 3.8-3.11 * build: remove pull request event for CI to avoid duplicate runs * test: add test cases for commands (Azure#40) * fix: error when register API with long description spec (Azure#41) * test: add test cases for optional parameters (Azure#42) * feat!: remove file name param (Azure#43) * fix: error not thrown when import spec with >3MB file (Azure#44) * feat!: remove state param for deployment commands (Azure#46) * fix: API title created by register command is not same with provided spec (Azure#47) * feat!: redesign parameters to specify APIM instance for import-from-apim command (Azure#45) * test: clean up legacy test cases (Azure#48) * test: add test cases for command examples (Azure#49) * docs: update help message per feedback (Azure#50) * build: bump version to 1.0.0 and add changelog (Azure#51) * fix: some parameters should be required in import-specification and deployment command (Azure#53) * feat!: rename parameter names to align with other Azure CLI command experience (Azure#52) * test: enable test for import-from-apim (Azure#54) * test: fix show service test case (Azure#55) * docs: update changelog for 1.0.0 (Azure#56) * Update HISTORY.rst - jukasper updated changelog * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * docs: update readme for apic-extension (#57) * fix: cannot run create command against existing resource (Azure#58) * fix: cannot run create command against existing resource * style: fix style * build: remove cicd pipeline (Azure#59) * build: resolve review comments (Azure#60) --------- Co-authored-by: Julia Kasper <42241691+juliajuju93@users.noreply.github.com>

* build: add cicd pipeline (#7) * build: move update version logic to workflow (#8) * build: Run CI on multiple python version (Azure#38) * build: Run CI in Python 3.8-3.11 * build: remove pull request event for CI to avoid duplicate runs * refactor: add apic api update example * tests: add test case * fix: fix style * fix: fix test case * fix: fix test case * fix: fix test case & add recording * fix: remove bad command prefix * refactor: optimize test case code * refactor: remove duplicate example for apic create * fix: fix style * feat: add examples for create & update apic service with system assigned identity * fix: fix external doc extracting bug in spec * fix: remove extra print * fix: fix style * fix: fix style * fix: fix style * fix: fix style * tests: fix test case * refactor: remove external docs from tags * tests: update test case * refactor: remove summary setting in api register * feat: support custom metadata export only * fix: fix test case * tests: add test case * fix: fix arg type * refactor: add help example * fix: fix bad logic of link format * refactor: remove extra example * refactor: update example * doc: update 1.0.1 release history * refactor: change note style * fix: fix * fix: remove breaking change label * build: bump version to 1.1.0 * Update V1.1.0 history (Azure#71) * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst --------- Co-authored-by: Julia Kasper <42241691+juliajuju93@users.noreply.github.com> * test: fix test cases * build: remove files to get ready for release --------- Co-authored-by: Chaoyi Yuan <blackchoey@gmail.com> Co-authored-by: Julia Kasper <42241691+juliajuju93@users.noreply.github.com>

vthiebaut10 added 4 commits October 15, 2021 13:28

Initial changes to clean up keys once connection is established

7b79f28

Add new parameter to config to decide credentials dir. Establish defa…

fd0a29d

…ult cred location for config

Not try to delete folder when user provided keys

9abf7ba

Deleting debug print statements

0f0f87d

bagajjal reviewed Oct 27, 2021

View reviewed changes

src/ssh/azext_ssh/_params.py Outdated Show resolved Hide resolved

bagajjal reviewed Oct 27, 2021

View reviewed changes

src/ssh/azext_ssh/custom.py Outdated Show resolved Hide resolved

bagajjal reviewed Oct 27, 2021

View reviewed changes

src/ssh/azext_ssh/custom.py Outdated Show resolved Hide resolved

bagajjal reviewed Oct 27, 2021

View reviewed changes

src/ssh/azext_ssh/custom.py Show resolved Hide resolved

bagajjal reviewed Oct 27, 2021

View reviewed changes

src/ssh/azext_ssh/ssh_utils.py Outdated Show resolved Hide resolved

bagajjal reviewed Oct 27, 2021

View reviewed changes

src/ssh/azext_ssh/ssh_utils.py Outdated Show resolved Hide resolved

bagajjal reviewed Oct 27, 2021

View reviewed changes

src/ssh/azext_ssh/ssh_utils.py Show resolved Hide resolved

bagajjal reviewed Oct 27, 2021

View reviewed changes

src/ssh/azext_ssh/ssh_utils.py Outdated Show resolved Hide resolved

bagajjal reviewed Oct 27, 2021

View reviewed changes

src/ssh/azext_ssh/ssh_utils.py Outdated Show resolved Hide resolved

bagajjal suggested changes Oct 27, 2021

View reviewed changes

vthiebaut10 added 6 commits October 28, 2021 15:17

Addressing review comments

67bee4e

Added certificate validity to config warning

c4076fc

update history and version

1939dab

changes to az ssh cert

bf324b8

Update History with ssh cert changes

7453864

Fixing some comments

0cc8db7