Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Updating vtex-io-documentation-running-native-ab-testing.md #903

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Doc: Updating vtex-io-documentation-running-native-ab-testing.md #903

merged 2 commits into from
Jan 11, 2024

Conversation

barbara-celi
Copy link
Contributor

Types of changes

  • New content (guides, endpoints, app documentation)
  • Improvement (make a documentation even better)
  • Fix (fix a documentation error)
  • Spelling and grammar accuracy (self-explanatory)

@barbara-celi barbara-celi added the new Improvements or additions to documentation label Jan 8, 2024
@barbara-celi barbara-celi self-assigned this Jan 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Preview Links

Open this URL to set up the portal with this branch changes.

You can now access the edited pages with the following URLs:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Navigation Preview Link

No changes detected in the navigation.json file

@barbara-celi @carolinamenezes
Apply suggestions from code review
9da619b 
Co-authored-by: Carolina Menezes <60782333+carolinamenezes@users.noreply.github.com>
barbara-celi
barbara-celi commented Jan 11, 2024
View reviewed changes
Copy link
Contributor Author

@barbara-celi barbara-celi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File was modified based on suggestions.

@mariana-caetano mariana-caetano self-requested a review January 11, 2024 17:42
mariana-caetano
mariana-caetano approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@mariana-caetano mariana-caetano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@barbara-celi barbara-celi merged commit 8f6123c into main Jan 11, 2024
4 checks passed
@barbara-celi barbara-celi deleted the barbara-celi-patch-1 branch January 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariana-caetano mariana-caetano mariana-caetano approved these changes

@carolinamenezes carolinamenezes Awaiting requested review from carolinamenezes

Assignees

@barbara-celi barbara-celi

Labels
new Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barbara-celi @carolinamenezes @mariana-caetano