Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings commands #316

Merged
merged 3 commits into from
Jul 17, 2017
Merged

Fix settings commands #316

merged 3 commits into from
Jul 17, 2017

Conversation

tamorim
Copy link
Contributor

@tamorim tamorim commented Jul 12, 2017

What is the purpose of this pull request?

Fix the behaviour of the settings commands and subcommands.

What problem is this solving?

Incorrect merge of app settings and inability to set a value that isn't a string.

How should this be manually tested?

Playing with the settings commands 😄

Screenshots or example usage

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Copy link
Contributor

@brunoabreu brunoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems jsonpath is not a toolbelt dependency anymore. We should remove it from package.json and yarn.lock.

@tamorim tamorim merged commit 2453879 into master Jul 17, 2017
@tamorim tamorim deleted the fix/settings branch July 17, 2017 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants