Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint issues across project #303

Merged
merged 1 commit into from
May 16, 2017
Merged

Fix lint issues across project #303

merged 1 commit into from
May 16, 2017

Conversation

tamorim
Copy link
Contributor

@tamorim tamorim commented May 16, 2017

What is the purpose of this pull request?

A lot of warnings from tslint 😂

What problem is this solving?

Code style consistency.

How should this be manually tested?

n/a

Screenshots or example usage

n/a

Types of changes

  • Lint fix
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@tamorim tamorim requested a review from drawveloper May 16, 2017 18:49
drawveloper
drawveloper approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@drawveloper drawveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drawveloper drawveloper merged commit dc4f2e0 into master May 16, 2017
@drawveloper drawveloper deleted the fix/code-style branch May 16, 2017 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drawveloper drawveloper drawveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamorim @drawveloper