This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
chore: Accept performance drop #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for basestore ready! 🔨 Explore the source changes: d37b5f5 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/6234b9ae34824d0008bd138d 😎 Browse the preview: https://deploy-preview-395--basestore.netlify.app |
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-395--base.preview.vtex.app |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 14m PerformanceLighthouse report
|
|
Do you happen to know why there was this sudden drop? |
b3988eb to
1b0e386
Compare
Webops changed the cluster where lighthouse CI was running. I think that it's working properly now |
filipewl
approved these changes
Mar 18, 2022
Co-authored-by: Filipe W. Lima <fwl.ufpe@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Recently, webops changed their cluster. This made lighthouse CI get a more realistic measurement to PageSpeedInsights. This, however, broke our minimum budgets.
This PR introduces a new minimium of 90 on lighthouse performance, and make pages that were not passing to start passing again.
Take a look at this PR too: vtex/faststore#1177