Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/login error #168

Merged
merged 16 commits into from
Oct 28, 2024
Merged

Fix/login error #168

merged 16 commits into from
Oct 28, 2024

Conversation

giurigaud
Copy link
Contributor

@giurigaud giurigaud commented Oct 22, 2024

What problem is this solving?

Buyers can't login if there is misconfiguration in organizations/cost centers

(REOPEN PR - change validation to check if cost center exists)

How should this be manually tested?

1- create Org
2- create CC1
3- create CC2
4- associate user 1 with CC1
5- associate user 1 with CC2
6- delete CC1
7- try to log in with user 1

Screenshots or example usage:

Before change
https://github.com/user-attachments/assets/c874c3a0-e458-4881-81d3-e6b52bda7a5e

After change

Uploading deleteCostCenter-afterChange.mov…

Screenshot 2024-10-02 at 11 48 42

Uploading deleteCostCenter-afterChange.mov…

Copy link

vtex-io-ci-cd bot commented Oct 22, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 22, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@enzomerca enzomerca requested a review from a team October 23, 2024 17:50
Copy link

github-actions bot commented Oct 24, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 9, PR deletions = 2

Generated by 🚫 dangerJS against 9fb56e8

Copy link

@enzomerca enzomerca merged commit ad83a38 into vtex-apps:master Oct 28, 2024
19 of 20 checks passed
Copy link

vtex-io-ci-cd bot commented Oct 28, 2024

Your PR has been merged! App is being published. 🚀
Version 1.45.0 → 1.45.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.storefront-permissions@1.45.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants