Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Feedback #3070 - Add the value prop #76

Merged
merged 8 commits into from
Jul 6, 2023

Conversation

mariana-caetano
Copy link
Contributor

@mariana-caetano mariana-caetano commented Jun 19, 2023

What problem is this solving?

This PR adds a prop value that can be passed to inputType when set to hidden. This prop set a pre-defined text in the input to be submitted.

You can find more information on the task EDU-9870 Feedback #2996 - Improvement

@mariana-caetano mariana-caetano self-assigned this Jun 19, 2023
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jun 19, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@mariana-caetano mariana-caetano marked this pull request as ready for review June 19, 2023 18:41
@mariana-caetano mariana-caetano requested a review from a team as a code owner June 19, 2023 18:41
@mariana-caetano mariana-caetano requested a review from a team as a code owner June 19, 2023 18:49
@mariana-caetano mariana-caetano changed the title Doc: Feedback #3070 - Add the prop value Doc: Feedback #3070 - Add the value prop Jun 19, 2023
mariana-caetano and others added 3 commits June 22, 2023 14:16
Co-authored-by: Carolina Menezes <60782333+carolinamenezes@users.noreply.github.com>
Co-authored-by: Carolina Menezes <60782333+carolinamenezes@users.noreply.github.com>
Co-authored-by: Carolina Menezes <60782333+carolinamenezes@users.noreply.github.com>
@mariana-caetano mariana-caetano added the documentation Improvements or additions to documentation label Jul 6, 2023
@mariana-caetano mariana-caetano merged commit 3cada09 into master Jul 6, 2023
@mariana-caetano mariana-caetano deleted the doc-add-value-prop branch July 6, 2023 18:02
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jul 6, 2023

Your PR has been merged! App is being published. 🚀
Version 0.10.0 → 0.10.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-form@0.10.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants