Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding format file by props to upload input #33

Merged
merged 7 commits into from
Mar 25, 2021

Conversation

santosluiz000
Copy link
Contributor

What problem is this solving?

Allowing customize the format type that input upload accepts

How to test it?

Go to Operating Agreement input and try to upload some file.

(To customize the format type, you must to open a store-theme and add a typeAccept prop in form-input.upload#upload element)

This is my workspace

Screenshots or example usage:

image

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 23, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

santosluiz000 and others added 4 commits March 23, 2021 17:20
Co-authored-by: Breno Calazans <breno@vtex.com.br>
Co-authored-by: Breno Calazans <breno@vtex.com.br>
Co-authored-by: Breno Calazans <breno@vtex.com.br>
@santosluiz000 santosluiz000 requested a review from klzns March 23, 2021 20:26
Copy link
Contributor

@klzns klzns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog entry

see #33 (comment)

Co-authored-by: Breno Calazans <breno@vtex.com.br>
@santosluiz000 santosluiz000 requested a review from klzns March 25, 2021 15:53
@klzns klzns merged commit f70b2f3 into master Mar 25, 2021
@klzns klzns deleted the feat/props-to-upload branch March 25, 2021 19:11
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 25, 2021

Your PR has been merged! App is being published. 🚀
Version 0.5.1 → 0.6.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-form@0.6.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants