Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change form-input.upload to render only on client to avoid breaking SSR #32

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

klzns
Copy link
Contributor

@klzns klzns commented Mar 17, 2021

What problem is this solving?

The block form-input.upload is breaking in SSR because of the component Tooltip from the styleguide.

image

How to test it?

Current behavior:
https://formupload--storecomponents.myvtex.com/contact-us

Fix:
https://breno--storecomponents.myvtex.com/contact-us

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@klzns klzns requested a review from a team as a code owner March 17, 2021 15:11
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 17, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Mar 17, 2021

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@klzns klzns merged commit 4d69902 into master Mar 17, 2021
@klzns klzns deleted the fix-ssr branch March 17, 2021 21:03
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 17, 2021

Your PR has been merged! App is being published. 🚀
Version 0.5.0 → 0.5.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-form@0.5.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants