Feat/adding upload input #31
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 Thank you so much for keeping our documentation up-to-date ❤️ |
|
There was a problem hiding this comment.
(btw, I commited some changes to your branch, make sure to git pull before working on it)
I think using draft-js might be to heavy on the client
Can we change to just use react-dropzone instead? We did something similar in styleguide's Dropzone:
Code: https://github.com/vtex/styleguide/blob/master/react/components/Dropzone/index.js
Docs: https://styleguide.vtex.com/#/Components/Forms/Dropzone
What's is the workspace to test? Can you include in the PR description?
I will see this, thanks! Workspace: https://luizdev2--b2bstore.myvtex.com/registration |
|
Pra mim ainda aparece upload |
Co-authored-by: Bia <52087100+guerreirobeatriz@users.noreply.github.com>
Pls, access this link: https://luizdev3--b2bstore.myvtex.com/registration |
react/components/Upload/Link.tsx
Outdated
| const { url } = contentState.getEntity(entityKey).getData() | ||
|
|
||
| return ( | ||
| <a href={url} className="blue"> |
There was a problem hiding this comment.
I don't have too much context, but why not use the render-runtime Link component?
There was a problem hiding this comment.
This file is unecessary. It was removed
Co-authored-by: Ícaro Azevedo <icaro.azevedo@vtex.com.br>
…ps/store-form into feat/adding-upload-input
react/components/Upload/Upload.tsx
Outdated
| return ( | ||
| <div className="vtex-styleguide-9-x-dropdown vtex-dropdown" ref={ref}> | ||
| <span className="db mb3 w-100 c-on-base t-small"> | ||
| Operating Agreement |
There was a problem hiding this comment.
@santosluiz000 you've added the definitions but you also need to add IOMessage here so it can internationalize correctly.
You should also use defineMessages function to declare all i18n strings you use inside react. Take a look here.
react/components/Upload/Upload.tsx
Outdated
| return ( | ||
| <div className="vtex-styleguide-9-x-dropdown vtex-dropdown" ref={ref}> | ||
| <span className="db mb3 w-100 c-on-base t-small"> | ||
| Operating Agreement |
There was a problem hiding this comment.
This is still here @santosluiz000, this message will not be internationalized if it stays like this.
Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com>
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Adding upload input on store-form
How to test it?
Access https://luizdev3--b2bstore.myvtex.com/registration and use the feature there.
Screenshots or example usage:
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗
![](put .gif link here - can be found under "advanced" on giphy)