-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including classes on searchBar to identify when is open and/or filled #792
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @igorpoubel , thank you for the PR, just a couple of simples changes:
- You forgot to add the CHANGELOG
- I think in this case you don't have to create new handles, just use
applyModifiers
, here is an example - Instead of
hasTerm
I think it would be betterfilled
andopened
as a modifier
@Klynger thanks for the notice on CHANGELOG I'll have to put a new manifest version (even not released) ou I'll just insert on the current version? For exemplo: option 1 - So I'll have to insert this way? option 2 - Or this way? (assuming a new release) I think is the option 1, am I right? |
No, you just add on |
@Klynger so I just have to do this? And the version and date will be added automatically. Right? |
You use |
@Klynger ohh, now I got it. Ok! Thanks. |
Hi @igorpoubel , after you make the changes you can request my review again so I can get notified to review your PR again |
Co-authored-by: Rafael Klynger <rafael.klynger@gmail.com>
Co-authored-by: Rafael Klynger <rafael.klynger@gmail.com>
Co-authored-by: Rafael Klynger <rafael.klynger@gmail.com>
@@ -186,7 +186,7 @@ const SearchBar = ({ | |||
<div | |||
className={classNames( | |||
'relative-m w-100', | |||
handles.searchBarInnerContainer | |||
applyModifiers(handles.searchBarInnerContainer, [isOpen ? 'opened' : '', inputValue ? 'filled' : '']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some lint problems, you can fix this by installing the dependencies from the root of the app and running yarn lint --fix
Beep boop 🤖 That's ok, I created an issue for this so we don't forget |
@all-contributors add @igorpoubel for code |
I've put up a pull request to add @igorpoubel! 🎉 |
What problem is this solving?
It includes classes to check if the result list is opened and if the input is filled
How should this be manually tested?
Checking if the class "open" will be included when starts to fill the input. And check if the class "hasTerm" is included when there is anything on input.
Workspace -> search for
file
Checklist/Reminders
README.md
.CHANGELOG.md
.Screenshots or example usage
When just filled (without focus)
When opened (focus)
Type of changes
Notes