Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/specification group filter #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LucasCastroJussi
Copy link

What does this PR do? *

Add condition from specification name to show specifications.

How to test it? *

1 - Enter the following WS: Workspace

2 - Scroll to the bottom of the page and see that before the footer there is duplicate content where we have a shelf Image 1

3 - On this shelf, only two specifications and their respective values ​​are being shown Image 2

4 - If, in the code, you remove the conditionBySpecName prop or leave it empty, all specifications will be shown Image 3

@LucasCastroJussi LucasCastroJussi requested a review from a team as a code owner March 10, 2021 22:20
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 10, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@LucasCastroJussi LucasCastroJussi requested review from icazevedo, vitorflg and victorhmp and removed request for a team March 10, 2021 22:20
@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@klzns
Copy link
Contributor

klzns commented Mar 25, 2021

@LucasCastroJussi can you explain what is the problem that this PR is trying to solve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants