add specification filter

[IncognitaDev]

What does this PR do? *

this PR add prop to filter specifications inside group specifications

How to test it? *

create a product specifications table and pass filter prop to product-specifications like filter props os product-specification-group but with specificationNames instead specificationGroups.

Describe alternatives you've considered, if any. *

Related to / Depends on *

[vtex-io-ci-cd]

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

• Patch (backwards-compatible bug fixes)

• Minor (backwards-compatible functionality)

• Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

• No thanks, I would rather do it manually 😞

[vtex-io-docs-bot]

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

• There's nothing new to document 🤔
• I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

• I just updated 🎉🎉

[igorbrasileiro]

Hey, can you leave a workspace to test it?

[IncognitaDev]

here https://luis--sudambeef.myvtex.com/assado-de-tira-argentino-sudambeef-seleccion/p

[igorbrasileiro]

I think a way to remove this mutability. Feel free to argue 😅

What do you think about this suggestion?

const identityNoop = <T extends any>(x) => x // type the generics better, if possible.

type specificationFilterFunction = (specificationName: string) => boolean

interface UseFilterSpecification {
  specification: Array<{ originalName: string }>
  filters: {
    show: specificationFilterFunction,
    hide: specificationFilterFunction,
  }
}

const filterSpecification = ({ specification, filters: { show, hide } }: UseFilterSpecification) => {
   return specifications.filter(({ originalName }) => show(originalName) && hide(originalName))
}

Suggested change

	let specifications = group.specifications;
	if (filter.specificationNames?.length > 0 && filter.type == 'show') {
	specifications = specifications.filter((specification) =>
	filter.specificationNames.includes(specification.originalName) )
	}
	if (filter.specificationNames?.length > 0 && filter.type == 'hide') {
	specifications = specifications.filter((specification) =>
	!filter.specificationNames.includes(specification.originalName) )
	}
	const specifications = filterSpecification({
	specifications: group.specifications,
	filters: {
	hide: filter.type === 'show' ? (specification) => filter.specificationNames.includes(specification) : identityNoop,
	show: filter.type === 'hide' ? !(specification) => !filter.specificationNames.includes(specification) : identityNoop
	}
	})

That's it 😄 , you can rename or change or even disagree. If you feel more comfortable discussing in Portuguese, we can switch to PT-BR.

[igorbrasileiro]

This suggestion seems not to escalate if we want to handle unlimited filters, but for now, it looks good.

[IncognitaDev]

I think a way to remove this mutability. Feel free to argue 😅

What do you think about this suggestion?

const identityNoop = <T extends any>(x) => x // type the generics better, if possible.

type specificationFilterFunction = (specificationName: string) => boolean

interface UseFilterSpecification {
  specification: Array<{ originalName: string }>
  filters: {
    show: specificationFilterFunction,
    hide: specificationFilterFunction,
  }
}

const filterSpecification = ({ specification, filters: { show, hide } }: UseFilterSpecification) => {
   return specifications.filter(({ originalName }) => show(originalName) && hide(originalName))
}

That's it 😄 , you can rename or change or even disagree. If you feel more comfortable discussing in Portuguese, we can switch to PT-BR.

I make some adapts to fix errors but i'm not find the cause of this error: Argument of type 'string' is not assignable to parameter of type 'never'.

This just appear in hide function.

[igorbrasileiro]

This suggestion seems not to escalate if we want to handle unlimited filters, but for now, it looks good.

[igorbrasileiro]

@IncognitaDev, we've created this [CONTRIBUTING.md] to help new contributions. Can you take a look there?

[IncognitaDev]

@IncognitaDev, we've created this [CONTRIBUTING.md] to help new contributions. Can you take a look there?

Sure, but I don't find it. Wich repo contains ?