Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add coupon into OrderCouponProvider #23

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hamorim
Copy link

@hamorim hamorim commented Dec 18, 2024

What problem is this solving?

Adding coupon back in order to be compatible with coupon component

How should this be manually tested?

Workspace

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Screenshots or example usage

Type of changes

✔️ Type of Change
✔️ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

@hamorim hamorim requested a review from a team as a code owner December 18, 2024 12:05
@hamorim hamorim requested review from evertonstrack and vmarcosp and removed request for a team December 18, 2024 12:05
Copy link

vtex-io-ci-cd bot commented Dec 18, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Dec 18, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@diegoleone
Copy link

@hamorim Can you please add the updates to the changelog file?

@iago1501
Copy link

@hamorim , could you add the workspace for the test? The one there is crashed... and also images if it has a visual impact would be great to understand the whole context of the change

@hamorim
Copy link
Author

hamorim commented Dec 19, 2024

@hamorim , could you add the workspace for the test? The one there is crashed... and also images if it has a visual impact would be great to understand the whole context of the change

Sure, you can use this workspace to test: https://demo191224--redcloudone.myvtex.com/.

Regarding the images, I won’t be able to share any since this change was related specifically to the context logic. There are no visual changes associated with it, and the components using this context remain visually unchanged.

@iago1501 iago1501 changed the title chore: add coupon into OrderCouponProvider feat: add coupon into OrderCouponProvider Dec 19, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Iago Espinoza <iago1501@gmail.com>
@hamorim hamorim requested a review from iago1501 December 19, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants