Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of login test #268

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Change order of login test #268

merged 2 commits into from
Mar 12, 2023

Conversation

thyarles
Copy link
Contributor

The login test was moved to after link app, as some apps may break the login process.

@thyarles thyarles requested a review from Syed-Vtex March 10, 2023 10:32
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 10, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@github-actions
Copy link

github-actions bot commented Mar 10, 2023

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 31, PR deletions = 23

Generated by 🚫 dangerJS against 36c3093

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@thyarles thyarles merged commit b5ff6c5 into main Mar 12, 2023
@thyarles thyarles deleted the ENGINEERS-1199 branch March 12, 2023 13:26
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 12, 2023

Your PR has been merged! App is being published. 🚀
Version 2.4.1 → 2.4.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.cy-runner@2.4.2

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants