Fixes for the test to run on windows (#71)

* Fixes for the test to run on windows
* Fix code-review comments

client/client_test.go

@@ -24,6 +24,14 @@ func NewTestClient() (c *Client) {
 	return
 }
 
+func TempDir(t *testing.T) string {
+	dir, err := ioutil.TempDir(os.TempDir(), "dcdr")
+	if err != nil {
+		t.Fatalf("ioutil.TempDir error: %s", err.Error())
+	}
+	return dir
+}
+
 var JSONBytes = []byte(`{
   "dcdr": {
     "features": {
@@ -210,7 +218,9 @@ func TestUpdateFeatures(t *testing.T) {
 	}`)
 
 	cfg := config.DefaultConfig()
-	cfg.Git.RepoPath = "/tmp"
+	dir := TempDir(t)
+	defer os.RemoveAll(dir)
+	cfg.Git.RepoPath = dir
 	c, _ := New(cfg)
 	c.UpdateFeatures(raw)
 
@@ -235,14 +245,17 @@ func TestClient_UpdateFeatures_Failure(t *testing.T) {
 		},`)
 
 	cfg := config.DefaultConfig()
-	cfg.Git.RepoPath = "/tmp"
+	dir := TempDir(t)
+	defer os.RemoveAll(dir)
+	cfg.Git.RepoPath = dir
 	c, _ := New(cfg)
 	c.UpdateFeatures(badUpdate)
 	assert.EqualValues(t, models.EmptyFeatureMap(), c.FeatureMap(), "Assert bad payload returns empty feature map")
 }
 
 func TestWatch(t *testing.T) {
-	p := "/tmp/decider.json"
+	tmpfile, err := ioutil.TempFile(os.TempDir(), "dcdr.json")
+	p := tmpfile.Name()
 	fm, err := models.NewFeatureMap(JSONBytes)
 	assert.NoError(t, err)
 	err = ioutil.WriteFile(p, JSONBytes, 0644)

config/config_test.go

@@ -4,13 +4,23 @@ import (
 	"os/user"
 	"testing"
 
+	"io/ioutil"
+
 	"os"
 
 	"fmt"
 
 	"github.com/stretchr/testify/assert"
 )
 
+func TempDir(t *testing.T) string {
+	dir, err := ioutil.TempDir(os.TempDir(), "dcdr")
+	if err != nil {
+		t.Fatalf("ioutil.TempDir error: %s", err.Error())
+	}
+	return dir
+}
+
 func TestDefaultConfig(t *testing.T) {
 	ConfigDir = "/tmp/does/not/exist"
 	cfg := LoadConfig()
@@ -41,7 +51,10 @@ func TestDefaultConfig(t *testing.T) {
 }
 
 func TestEnvOverride(t *testing.T) {
-	os.Setenv(envConfigDirOverride, "/tmp/dcdr")
+	dir := TempDir(t)
+	defer os.RemoveAll(dir)
+
+	os.Setenv(envConfigDirOverride, dir)
 	cfg := LoadConfig()
 
 	assert.Equal(t, Path(), fmt.Sprintf("%s/%s", os.Getenv(envConfigDirOverride), configFileName))