Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

コード整理 #887

Merged
merged 4 commits into from
Apr 19, 2021
Merged

コード整理 #887

merged 4 commits into from
Apr 19, 2021

Conversation

ousttrue
Copy link
Contributor

  • MeshUtiilty にあった共通ユーティリティを、UniGLTF配下に移動した
    • Validation(Exportダイアログでエクスポートできるか検証)
    • 多言語メッセージ機能(日本語と英語のメッセージ切り替え)
  • MeshUtility が asmdef を独自に保持していたのをやめて、UniGLTF.Runtime, UniGLTF.Editor に分配した

vrm0, glb, vrm1 で共通に使う。

#869 も関連

@ousttrue ousttrue requested review from hiroj, Santarh, PoChang007 and Kohei-Yanagida and removed request for hiroj April 19, 2021 06:43
@ousttrue ousttrue merged commit 195abfa into vrm-c:master Apr 19, 2021
@ousttrue ousttrue deleted the feature/code_move branch May 17, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kohei-Yanagida Kohei-Yanagida Kohei-Yanagida approved these changes

@Santarh Santarh Awaiting requested review from Santarh

@PoChang007 PoChang007 Awaiting requested review from PoChang007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ousttrue @Kohei-Yanagida