[1.0] Importerを修正 #882
Merged
[1.0] Importerを修正 #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ousttrue
commented
Apr 16, 2021
- VRM部分(SpringBone, Constraint)で座標変換が無かった
Mesh, Node は、VrmLib.Model を介して座標変換されている。
Santarh
requested changes
Apr 16, 2021
Assets/VRM10/Tests/MigrationTests.cs
Outdated
| var colliderNodeIndex = spring.Colliders[0]; | ||
|
|
||
| Assert.True(UniGLTF.Extensions.VRMC_node_collider.GltfDeserializer.TryGet(parser1.GLTF.nodes[colliderNodeIndex].extensions, out UniGLTF.Extensions.VRMC_node_collider.VRMC_node_collider colliderGroup)); | ||
| Assert.AreEqual(-VALUE, colliderGroup.Shapes[0].Sphere.Offset[0]); |
There was a problem hiding this comment.
ヨシ！
直感的ではないが、VRM 0.x の事情と、1.0 への変換を色々やると結局考慮すると X だけが反転する、とのこと。
ただ Test としては Y と Z の値の Assert もやっといたほうがよさそう
Santarh
approved these changes
Apr 16, 2021
| // x軸だけが反転する | ||
| Assert.AreEqual(-VALUE.x, colliderGroup.Shapes[0].Sphere.Offset[0]); | ||
| Assert.AreEqual(VALUE.y, colliderGroup.Shapes[0].Sphere.Offset[1]); | ||
| Assert.AreEqual(VALUE.z, colliderGroup.Shapes[0].Sphere.Offset[2]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.