Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/unintended null reference after exporting #736

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Fix/unintended null reference after exporting #736

merged 1 commit into from
Feb 10, 2021

Conversation

ichi-23
Copy link
Contributor

@ichi-23 ichi-23 commented Feb 10, 2021

Fixes an issue where gltfExporter.Copy becomes null after calling gltfExporter.Export() when exporting a root-only object.

ousttrue
ousttrue approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UniGLTF assigns a root node to the gltf scene during the export. In special cases where there is only one node, a temporarily empty node is used as the parent instead of the "scene".

@ousttrue ousttrue merged commit a796c40 into vrm-c:master Feb 10, 2021
ousttrue added a commit to ousttrue/UniVRM that referenced this pull request Feb 10, 2021
@ousttrue
m_tmpParent
bbec3b8 
vrm-c#736
@ousttrue ousttrue mentioned this pull request Feb 10, 2021
Merged
@ousttrue ousttrue added this to the v0.67 milestone Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousttrue ousttrue ousttrue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.67
Development

Successfully merging this pull request may close these issues.
2 participants
@ichi-23 @ousttrue