最近の UnitTest #1044
Merged
最近の UnitTest #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ousttrue
commented
Jun 16, 2021
- [1.0] SpringBone の JsonSchema 変更対応
- Mtoon マイグレーション。enum 不正値対応
- ImporterContext.Load 関数の呼び出しでテクスチャが ImporterContext から GameObject に移動することに対応
Santarh
previously approved these changes
Jun 16, 2021
| @@ -16,14 +16,14 @@ public class RuntimeGltfInstance : MonoBehaviour, IResponsibilityForDestroyObjec | |||
| /// </summary> | |||
| public GameObject Root => this.gameObject; | |||
|
|
|||
| List<(SubAssetKey, UnityEngine.Object)> m_resources = new List<(SubAssetKey, UnityEngine.Object)>(); | |||
| public List<(SubAssetKey, UnityEngine.Object)> Resources = new List<(SubAssetKey, UnityEngine.Object)>(); | |||
There was a problem hiding this comment.
public にするのは IReadOnlyList だけのほうがよくないかな
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.