Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IAnimationImporter を廃止 #1014

Merged
merged 3 commits into from
Jun 8, 2021
Merged

IAnimationImporter を廃止 #1014

merged 3 commits into from
Jun 8, 2021

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Jun 8, 2021 •
edited
Loading

IAnimation を廃止。

  • virtual async Task ImporterContext.LoadAnimationAsync
  • virtual async Task ImporterContext.SetupAnimationsAsync

に責務を分離した。
extensions による挙動変更は、継承で実装する。

Editor 時の挙動変更(Asset化して、ExternalObjectMapになる)は、

  • ImporterContext.LoadAnimationAsync
  • Extract
  • ExternalObjectMap として取得
  • Load(LoadAnimationAsync + SetupAnimationsAsync)

という呼び出しを想定。

@ousttrue ousttrue requested review from Santarh and hiroj June 8, 2021 09:26
Santarh
Santarh approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

override か～という気持ちはあるが、Texture や Material とは違って仕方なさそうだなという感じだった

@ousttrue ousttrue merged commit 084a8ea into vrm-c:master Jun 8, 2021
@ousttrue ousttrue deleted the feature/remove_IAnimationImporter branch October 27, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santarh Santarh Santarh approved these changes

@hiroj hiroj Awaiting requested review from hiroj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ousttrue @Santarh