Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed window will never show up again if the window is closed when minimized #977

Conversation

ColorlessColor
Copy link
Contributor

@ColorlessColor ColorlessColor commented Nov 10, 2024

Show() must be called before changing WindowState, otherwise the internal state of the window will be messed up.

If you don't do this, if the window is closed when minimized, even if you click the tray menu icon, it will never show up on Windows 10.

…internal state of the window will be messed up.

If you don't do this, when the window is closed when minimized, even if you click the tray menu icon, it will never show up.
…e minimized, it should be restore to maximized when `Focus_Window` called.
@ColorlessColor
Copy link
Contributor Author

If window was maximized before minimized, it should be restore to maximized when Focus_Window() called.

@Natsumi-sama Natsumi-sama merged commit c052a28 into vrcx-team:master Nov 11, 2024
Natsumi-sama pushed a commit to Natsumi-sama/VRCX that referenced this pull request Nov 11, 2024
…nimized (vrcx-team#977)

* `Show()` must be called before changing `WindowState`, otherwise the internal state of the window will be messed up.

If you don't do this, when the window is closed when minimized, even if you click the tray menu icon, it will never show up.

* Remember window state before minimized. If window was maximized before minimized, it should be restore to maximized when `Focus_Window` called.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants