Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Startup Args #946

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Rework Startup Args #946

merged 7 commits into from
Oct 21, 2024

Conversation

DubyaDude
Copy link
Member

  • Rework startup arguments handling.
  • Prevent duplicate instances of the same config directory from starting.
  • Preserve startup arguments on upgrade restart.

@DubyaDude
Copy link
Member Author

DubyaDude commented Oct 19, 2024 •
edited
Loading

Need to do before change from Draft to PR

  • Get the difference between subprocess/main process when checking the duplicated config directory (To support having an instance launched with a custom directory, then launching an instance with no custom directory)

@DubyaDude DubyaDude marked this pull request as ready for review October 19, 2024 22:41
@DubyaDude
Copy link
Member Author

Ok, I'm actually done now, should be good to go

@Natsumi-sama Natsumi-sama merged commit 4f34e2d into vrcx-team:master Oct 21, 2024
Natsumi-sama pushed a commit to Natsumi-sama/VRCX that referenced this pull request Oct 21, 2024
@DubyaDude @Natsumi-sama
Rework Startup Args (vrcx-team#946)
8cab3d9 
* Rework startup args

* Preserve previous startup args on re-launch

* Ignore subprocess when checking for duplicate processes

* Cleanup code

* Remove extra process list grabbing

* Use `IsUpgradePrefix` when using `RestartApplication`

* Change `ProxyServerPrefix` to `ProxyUrlPrefix`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DubyaDude @Natsumi-sama