improve search matching significantly for special characters and characters that look similar to latin characters #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acters that look similar to latin characters searching using characters in other scripts should see slight improvements, but i dont expect much difference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
searching using characters in other scripts should see slight improvements, but i dont expect much difference
these improvements apply to the friends list and sidebar friends list. because other tabs use sqlite's native pattern matching, i can't improve on those. in order to improve them in the future we would have to store cleaned versions of values we'd like to search. the most benefit would be on displayname. however, even with that we would not be able to use the
localeIncludesmethod i made, leaving some room for improvement.