feat: kill install process after exiting game #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DubyaDude
suggested changes
Aug 6, 2024
| /// <returns>The number of processes that were killed (0 or 1).</returns> | ||
| public int KillInstall() | ||
| { | ||
| var processes = Process.GetProcessesByName("install"); |
There was a problem hiding this comment.
I'm a bit hesitant about the way install.exe is being grabbed here. While it makes sense for vrchat because the likelihood of the same application existing is little to none, install can very much encompass more processes that may be unintentionally killed.
There was a problem hiding this comment.
Detect if install.exe is in VRChat folder with regular expression
Natsumi-sama
pushed a commit
to Natsumi-sama/VRCX
that referenced
this pull request
Aug 7, 2024
* feat: kill install process after exiting game * Restore en.json * fix some key incorrect * gui: update for VRChat OSC Fix * fix: may incorrectly kill unrelated processes * fix: pattern incorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix https://vrchat.canny.io/bug-reports/p/installexe-breaks-osc-port-binding