Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unlimited local avatar favs #845

Merged

Conversation

Nekromateion
Copy link
Contributor

Implement unlimited local avatar favs with VRC+ requirement.

Implement unlimited local avatar favs with VRC+ requirement.
Modify translation files to use the same string used for world favs since it's the same now.
@Nekromateion Nekromateion force-pushed the local-unlimited-avatar-favs branch from a5a286c to a86f669 Compare July 22, 2024 05:46
@Natsumi-sama Natsumi-sama merged commit 652783c into vrcx-team:master Jul 22, 2024
@bornato
Copy link

bornato commented Jul 30, 2024

wait why vrc+ requirement if it's local database only and for you to change into them you gotta completely reboot the game?

@Myrkie
Copy link
Contributor

Myrkie commented Jul 30, 2024

wait why vrc+ requirement if it's local database only and for you to change into them you gotta completely reboot the game?

Because making it non VRCPlus would make VRCPlus pointless thus interfering with VRChats source of income, VRChats has made it very clear in the past they don't want this to happen (such as with EMMvrc the mod for VRChat having to lock unlimited avatars behind VRCPlus ownership)

@Nekromateion
Copy link
Contributor Author

Nekromateion commented Jul 30, 2024

wait why vrc+ requirement if it's local only and for you to change into them you gotta completely reboot the game?

You don't have to restart your game to switch into the Avatars, I do not know where you got that from.
Like @Myrkie said undermining part of VRChats source of monetization would not be a good idea and has caused issues in the past.

@Myrkie
Copy link
Contributor

Myrkie commented Jul 30, 2024

yeah for clarification changing avatar from the website or VRCX is not a VRCPlus requirement (unless vrchat changes their mind), only local favorites are locked behind owning VRCPlus for the above reasons.

@bornato
Copy link

bornato commented Jul 30, 2024

wait why vrc+ requirement if it's local database only and for you to change into them you gotta completely reboot the game?

Because making it non VRCPlus would make VRCPlus pointless thus interfering with VRChats source of income, VRChats has made it very clear in the past they don't want this to happen (such as with EMMvrc the mod for VRChat having to lock unlimited avatars behind VRCPlus ownership)

i believe having it non vrc+ would make people annoyed enough for having to mess around with their favorites all the time to actively want to buy vrc+, sounds counter intuitive to me if the idea is to get people to want to buy it (considering how to get people to actively want to engage with your product)

although i guess it's also fair to just be safe enough, since the community is not responsible for how they plan out the game's finance (and we've had issues with stuff like that with the API before as well, not only on VRCX)

wait why vrc+ requirement if it's local only and for you to change into them you gotta completely reboot the game?

You don't have to restart your game to switch into the Avatars, I do not know where you got that from.

If you don't have to restart anymore that's new to me, I got so used to not being able I just gave up entirely on even bothering with it

@Myrkie
Copy link
Contributor

Myrkie commented Jul 30, 2024

If you don't have to restart anymore that's new to me, I got so used to not being able I just gave up entirely on even bothering with it

yep the change was made 4 months ago now as apart of an open beta update before it was pushed to live

Link to VRChat discord message
image

@extremeblackliu
Copy link

extremeblackliu commented Aug 27, 2024

translation is wrong till latest version (2024.07.29).
https://github.com/vrcx-team/VRCX/pull/845/files#diff-af9254c4cffd2f02ec309237af67573be0b6f9d22069aab754ee5768a678f7a8R769

to above:
this is open-source software no idea why you guys complain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants