Fixed bulk unfriend checkboxes remain checked on the friends at the same position after turned page #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the same position after turned to the other page
Natsumi-sama
pushed a commit
to Natsumi-sama/VRCX
that referenced
this pull request
Jun 26, 2024
…t the same position after turned to the other page (vrcx-team#833) Co-authored-by: EbonCorvin <{ID}+{username}@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the user selected friends under bulk unfriend mode, the checkbox at the same position would remain visibly checked if they turned to another page, even if the friends they selected are complete different person.
I.e: The user checked friend A, who is at the 10th position on the 1st page of friend list, and then they turned to 2nd page. Friend B, who is also at the 10th position but on the 2nd page would also be checked, even though only friend A is selected in the internal data.