Show Headset Battery in VR Overlay #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not have a dedicated PCVR headset (without a battery) myself, so I would appreciate some testing that this does not explode with such a headset. It should simply skip displaying the headset. |
|
Commit looks really good, I'll test with my cable headset later today. |
|
It does indeed skip the headset nice, will merge with next nightly update, lemme know if there is anything else you're interesting in doing and I'll help you find what you need. |
|
I have some ideas, but I think those will take me a few days of experimentation. So don't wait for that. |
|
Well feel free to message me on Discord "NatsumiDa" with any questions or if you'd like to know if something is viable with this code base. |
Natsumi-sama
pushed a commit
to Natsumi-sama/VRCX
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #741