Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish localization (synchronized with crowdin) #734

Merged
merged 29 commits into from
Feb 27, 2024

Conversation

BlueOvi
Copy link
Contributor

@BlueOvi BlueOvi commented Feb 2, 2024

No description provided.

@migue802
Copy link
Contributor

migue802 commented Feb 2, 2024

Please don't merge, we're still working on it

@BlueOvi BlueOvi marked this pull request as draft February 2, 2024 11:33
@migue802
Copy link
Contributor

migue802 commented Feb 2, 2024

88a8f0c i'm not adding any new translation, but fixing those who are in the en.json file but not implemented on the code

@migue802
Copy link
Contributor

migue802 commented Feb 3, 2024

There's an issue with some dropdowns that have translations declared on a js object, some aren't replaced with translations

image
image

@migue802
Copy link
Contributor

migue802 commented Feb 5, 2024

There's an issue with some dropdowns that have translations declared on a js object, some aren't replaced with translations

After investigating a little, it seems the issue is caused by the language being loaded after getting these strings. So, possible solutions:

  • Crappy way: put these vars at the bottom of the script
  • Good way: update this vars on initLanguage()

Will try the good way lol

@migue802
Copy link
Contributor

migue802 commented Feb 5, 2024

Anyways, I think it would be better to create another PR to fix all the missing translations, so I'll leave this conclusions there.

Still, I'll upload the temp solution to this issue lol
image

@migue802
Copy link
Contributor

migue802 commented Feb 5, 2024

The strings are 100% translated, Spanish is now in the review stage

@BlueOvi BlueOvi changed the title Adding Spanish Language to master branch Add Spanish localization (synchronized with crowdin) Feb 13, 2024
@migue802
Copy link
Contributor

migue802 commented Feb 27, 2024

Sorry for the inactivity.
First of all, after another test (ignoring all the big strings that make the UI a bit ugly, and missing translations) everything seems fine and correctly translated to Spanish.

@BlueOvi kindly please un-draft the pr pls :)

@Natsumi-sama whenever you can please review this temporary solution, and if needed, propose or edit the file with a better one.

EDIT: This is a MVP tho as it remains a lot of work to make the Spanish language look good in the UI

@BlueOvi BlueOvi marked this pull request as ready for review February 27, 2024 17:39
@Natsumi-sama Natsumi-sama merged commit 176b599 into vrcx-team:master Feb 27, 2024
@Natsumi-sama
Copy link
Member

I'll merge this into the nightly build, widen any columns that are overflowing by a few characters and check over that temporary solution. Feel free to make another PR after for touch ups or extra translations.

Natsumi-sama added a commit to Natsumi-sama/VRCX that referenced this pull request Feb 29, 2024
* Add files via upload

* Update README.es_ES.md

* Create en.json

* Update README.es_ES.md

* Update README.es_ES.md

* Update en.json

* updated spanish json, added lang

* Rename README.es_ES.md to README.es.md

* Update README.md

Spanish has been added to the list of available languages.

* Update README.fr.md

Spanish has been added to the list of available languages.

* Update README.it.md

Spanish has been added to the list of available languages.

* Update README.jp.md

Spanish has been added to the list of available languages.

* Update README.ru_RU.md

Spanish has been added to the list of available languages.

* Update README.zh_CN.md

Spanish has been added to the list of available languages.

* Fixed translation tags on profile tab

* [Implem. Fix] Past names

* Updating strings

* Update localization strings in en.json

* Temporary fix to world clasification dropdown localization

* Updating spanish translations

* Update translations

* Removing things my vscode changed lol

* Updating spanish translations

---------

Co-authored-by: Miguel Campo (migue802) <contact@migue802.com>
Co-authored-by: migue802 <54627022+migue802@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants