NET 8 Upgrade #687
NET 8 Upgrade #687
Conversation
|
natsumi is going to kill you. |
|
Not sure if this is something to pursue when there's the winter rewrite project that plans to utilize NET 8. also, Switching from framework -> net will also cause issues of people not having runtime installed if you don't to a self-contained build. |
The first part is fair, and the second one I see the concern, but Windows will prompt you to install the runtime. |
can confirm the second part, I was sent a test build without .net 8 installed and it brought me straight to the direct download, no fussing around on a page to find the correct one. |
Didn't know that, neat |
|
We could always modify the installer to bundle .NET 8 if it is an issue. |
|
Well, putting that aside, I don't think it's great to switch core tech as the rewrite is over the horizon (I took 3 weeks off in December purely for it, so progress will definitely be made by the end of the year). The last thing I want is for a slew of new issues possibly popping up from this. |
We can always keep it on hold and see how far along we are in mid-December as there's no guarantee it'll be nowhere near ready by then. Plus it's not even merge-ready as there are some issues I have to resolve. |
5deb396 to
99a6db9
Compare
I regret NSIS
|
LGTM, ship it to prod |
8adf27f to
cefe1e1
Compare
* Initial .NET8 Upgrade * Initial GitHub Actions Cleanup * Fix Desktop Notifications * Fix throw warning * Upgrade vunerable transative nuget packages * Fix warnings with registry overflow * Adjust async/await usage for configRepository * Fix TTS voice name and app auto start * Install .NET 8 with setup I regret NSIS * Remove no longer needed System/MS references (included in dotnet sdk) * Surpress stackalloc in loop warning, that code scares me. * Removed unused SharpDX packages * Ignore WebClient warning, hopefully this project doesn't move past NET 8 * Fixed terrifying code * GenerateAssemblyInfo * Trimmed editor config to only silence warning. * Fix open webpage * Fix updater --------- Co-authored-by: DubyaDude <ushafiq141@gmail.com> Co-authored-by: Natsumi <cmcooper123@hotmail.com>
|
Hello, just a heads up. I installed the latest nightly with this upgrade and got this on Windows 10:
Clicking on the link and installing the runtime doesn't fix the issue though. It keeps re asking to install it. |
make sure to download the .net Desktop Runtime https://dotnet.microsoft.com/en-us/download/dotnet/8.0 Direct: desktop runtime |
|
Did you install with setup or zip? what's your Windows version? try reboot. |
I did, that's the same thing that got linked by the dialog. Now that setup only offers me to modify or repair the install which I tried.
Originally I used the automatic Nightly upgrade, but now also tried the zip file from commit 312519b with the same issue. The windows version is Windows 10 Pro 22H2: Tried rebooting multiple times, but the issue persists. Also tried running it from the cmd but it just pops up that window instantly. |
|
Might be better to make this an issue rather than have it in this PR since it is now on nightly. |
|
@Okabintaro please create an issue for this including all the information so we can diagnose and track it. I may have a potential fix, but would rather continue that discussion on an issue. |
This is a very early implementation of upgrading VRCX to .NET 8 from .NET Framework 4.7.2.