Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Wrong Country Flag Used On Language #816

Closed
ShanaNyaa opened this issue Jun 13, 2024 · 1 comment
Closed

[Bug] Wrong Country Flag Used On Language #816

ShanaNyaa opened this issue Jun 13, 2024 · 1 comment
Labels
bug Something isn't working done Completed and included in next release

Comments

@ShanaNyaa
Copy link
Contributor

Describe the bug
Language "Bahasa Melayu" (known as msa in VRC) is using Indonesian flag.

To Reproduce
Steps to reproduce the behavior:

  1. Add Bahasa Melayu language to your bio or find a friend that use Bahasa Melayu as their language in their bio
  2. Observe the flag used

Expected behavior
It should show Malaysia flag.

Screenshots
image

What version you are running
Version 2024.05.09

Extra detail
I saw that in the code html/src/app.js under variable "LanguageMappings" both Bahasa Melayu and Bahasa Indonesia is using "id". I do not know how the code works but perhaps using "my" for Bahasa Melayu is the fix for this.
@ShanaNyaa ShanaNyaa added the bug Something isn't working label Jun 13, 2024
@Natsumi-sama
Copy link
Member

@hyblocker can you give this a look if you have the time.

ShanaNyaa added a commit to ShanaNyaa/VRCX that referenced this issue Jun 22, 2024
@ShanaNyaa
Update flags to support Bahasa Melayu language (vrcx-team#816)
6cbef4c 
Update Malaysia flag to support Bahasa Melayu language
Natsumi-sama pushed a commit that referenced this issue Jun 26, 2024
@ShanaNyaa
Update flags to support Bahasa Melayu language (#816) (#829)
3ab1cf1 
Update Malaysia flag to support Bahasa Melayu language
Natsumi-sama pushed a commit to Natsumi-sama/VRCX that referenced this issue Jun 26, 2024
@ShanaNyaa @Natsumi-sama
Update flags to support Bahasa Melayu language (vrcx-team#816) (vrcx-…
5d1f6a4 
…team#829)

Update Malaysia flag to support Bahasa Melayu language
@Natsumi-sama Natsumi-sama added the done Completed and included in next release label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working done Completed and included in next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Natsumi-sama @ShanaNyaa