Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Latest Package" for webpage deployment does not respect semantic versioning order #18

Closed
techanon opened this issue Jul 7, 2023 · 3 comments

Comments

@techanon
Copy link

techanon commented Jul 7, 2023

I have a repo listing with a large amount of pre-release versions. When I check my listing for the latest version of one of my repos that has more than 1 digit in a version numbering, it shows the wrong version.

Example:

  • Go to vpm.techanon.dev
  • Click on the (i) for ProTV
  • Latest should be v3.0.0-alpha.18 (or later)
  • Currently shows v3.0.0-alpha.9.1 (and it's associated dependency versions that are also out of date)

This is incorrect. After looking through the repo a bit I believe this line is the issue
https://github.com/vrchat-community/package-list-action/blob/main/PackageBuilder/Build.cs#L237
as it seems to only sort for the "latest package" via descending unicode sort instead of via semantic version syntax.

I would expect it to order the packages according to the same sorting algorithm that the actual JSON listing itself gets sorted by.

LauraRozier added a commit to LauraRozier/package-list-action that referenced this issue Jul 30, 2023
@LauraRozier
Copy link

For now you can use my little edit, until they reviewed and accepted or made their own version.
You can use mine by editing the /.githubworkflows/build-listing.yml file of your package-listing page.

Here is my commit to my own that shows the minor change you'll have to make:
LauraRozier/LauraVRCUtils@7446425

@Spokeek
Copy link

Spokeek commented Nov 8, 2023

That looks interesting to have, maybe make a PR to this repo as well so vrc can integrate it at some point.

@orels1
Copy link
Contributor

orels1 commented Nov 26, 2024

This should be addressed by #31
Thanks @JLChnToZ !

@orels1 orels1 closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants