-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fields sequence if it's required (need help) #914
Merged
+183
−2
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
847ec16
add fields sequence if it's required
vfrbgt f382547
add test and fix get sequence element method (not ended)
vfrbgt 4cecdec
sequence set for wsdl files where params right parsed in wsdl.js
vfrbgt f94684c
fix style
vfrbgt 73dcc1d
sequence args if sequence args is known
vfrbgt 7b5feec
fix sequence reuire check
vfrbgt 923cfb6
fix test wrong parsed params for sequnce
vfrbgt b59b1e7
code style fixes
vfrbgt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
'use strict'; | ||
|
||
var fs = require('fs'), | ||
soap = require('..'), | ||
http = require('http'), | ||
assert = require('assert'), | ||
_ = require('lodash'), | ||
sinon = require('sinon'), | ||
wsdl = require('../lib/wsdl'); | ||
|
||
var sequencedRequest = { | ||
'url': 'https://github.com', | ||
'fileName': 'qwe.txt', | ||
'fileMode': 1, | ||
'forceOverwrite': true, | ||
'username': 'qwert', | ||
'password': 'qwerty', | ||
'base64EncodedCallback': '123' | ||
}; | ||
|
||
var notSequencedRequest = { | ||
'password': 'qwerty', | ||
'base64EncodedCallback': '123', | ||
'username': 'qwert', | ||
'forceOverwrite': true, | ||
'fileMode': 1, | ||
'fileName': 'qwe.txt', | ||
'url': 'https://github.com' | ||
}; | ||
|
||
describe('Method args sequence', function() { | ||
|
||
it('check if method required sequence args', function(done) { | ||
soap.createClient(__dirname + '/wsdl/rpcexample.wsdl', { suffix: '', options: {} }, function(err, client) { | ||
assert.ok(client); | ||
assert.ok(client._isSequenceRequired('pullFile') === false); | ||
|
||
soap.createClient(__dirname + '/wsdl/sequnceexmple.wsdl', { suffix: '', options: {} }, function(err, client) { | ||
assert.ok(client); | ||
assert.ok(client._isSequenceRequired('pullFile') === true); | ||
done(); | ||
}); | ||
}); | ||
}); | ||
|
||
it('check sort args on sequence required method', function(done) { | ||
soap.createClient(__dirname + '/wsdl/sequnceexmple.wsdl', { suffix: '', options: {} }, function(err, client) { | ||
assert.ok(client); | ||
var sequencedMethodRequest = client._setSequenceArgs(client._getArgsScheme('pullFile'), notSequencedRequest); | ||
assert.ok(JSON.stringify(sequencedMethodRequest) === JSON.stringify(sequencedRequest)); | ||
done(); | ||
}); | ||
}); | ||
|
||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<definitions xmlns:tns="urn:RpcExample" xmlns:SOAP-ENV="http://www.w3.org/2003/05/soap-envelope" | ||
xmlns:SOAP-ENC="http://www.w3.org/2003/05/soap-encoding" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" | ||
xmlns:RpcExample="urn:RpcExample" xmlns:SOAP="http://schemas.xmlsoap.org/wsdl/soap12/" | ||
xmlns:MIME="http://schemas.xmlsoap.org/wsdl/mime/" | ||
xmlns:DIME="http://schemas.xmlsoap.org/ws/2002/04/dime/wsdl/" xmlns:WSDL="http://schemas.xmlsoap.org/wsdl/" | ||
xmlns="http://schemas.xmlsoap.org/wsdl/" name="urn:RpcExample" targetNamespace="urn:RpcExample"> | ||
<types> | ||
<schema xmlns:SOAP-ENV="http://www.w3.org/2003/05/soap-envelope" | ||
xmlns:SOAP-ENC="http://www.w3.org/2003/05/soap-encoding" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" | ||
xmlns:RpcExample="urn:RpcExample" xmlns="http://www.w3.org/2001/XMLSchema" | ||
targetNamespace="urn:RpcExample" elementFormDefault="unqualified" attributeFormDefault="unqualified"> | ||
<import namespace="http://www.w3.org/2003/05/soap-encoding"/> | ||
<element name="pullFile"> | ||
<complexType> | ||
<sequence> | ||
<element name="url" type="xsd:string" minOccurs="1" maxOccurs="1"/> | ||
<element name="fileName" type="xsd:string" minOccurs="1" maxOccurs="1"/> | ||
<element name="fileMode" type="xsd:int" minOccurs="1" maxOccurs="1"/> | ||
<element name="forceOverwrite" type="xsd:boolean" minOccurs="1" maxOccurs="1"/> | ||
<element name="username" type="xsd:string" minOccurs="1" maxOccurs="1"/> | ||
<element name="password" type="xsd:string" minOccurs="1" maxOccurs="1"/> | ||
<element name="base64EncodedCallback" type="xsd:string" minOccurs="1" maxOccurs="1"/> | ||
</sequence> | ||
</complexType> | ||
</element> | ||
</schema> | ||
</types> | ||
<message name="pullFileRequest"> | ||
<part name="parameters" element="tns:pullFile"/> | ||
</message> | ||
<message name="pullFileResponse"> | ||
<part name="parameters" type="xsd:boolean"/> | ||
</message> | ||
<portType name="RpcExamplePortType"> | ||
<operation name="pullFile"> | ||
<documentation xmlns:wsdl="http://schemas.xmlsoap.org/wsdl/">Generate an indicium.</documentation> | ||
<input message="tns:pullFileRequest"/> | ||
<output message="tns:pullFileResponse"/> | ||
</operation> | ||
</portType> | ||
<binding name="RpcExample" type="tns:RpcExamplePortType"> | ||
<SOAP:binding style="rpc" transport="http://schemas.xmlsoap.org/soap/http"/> | ||
<operation name="pullFile"> | ||
<SOAP:operation style="rpc"/> | ||
<input> | ||
<SOAP:body use="encoded" namespace="urn:RpcExample" | ||
encodingStyle="http://www.w3.org/2003/05/soap-encoding"/> | ||
</input> | ||
<output> | ||
<SOAP:body use="encoded" namespace="urn:RpcExample" | ||
encodingStyle="http://www.w3.org/2003/05/soap-encoding"/> | ||
</output> | ||
</operation> | ||
</binding> | ||
<service name="RpcExample"> | ||
<port name="RpcExample" binding="tns:RpcExample"> | ||
<SOAP:address location="http://127.0.0.1/"/> | ||
</port> | ||
</service> | ||
</definitions> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to revert to v.0.18.0 as this breaks node-soap. When a client is formed from a WSDL and it has an array inside nested object in input like this (the way client.describe() tells):
It will ignore given array in input
PeriodType: [...]
, but will accept"PeriodType[]": {}
and it will generate malformed XML by generating<PeriodType[]></PeriodType[]>
element.v.0.18.0 Works as expected by accepting
PeriodType: [...]
, also works when this if is disabledif(false && this._isSequenceRequired(name)) {