Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellanious refactors to unit testing, allowing for different clause pattern to check against when running tests.
i.e. the new
GenerationTester
can not only check whether the result of a rule application is exactly some list of clauses (ExactlyStackMatcher
) but also whether e.g. the resulting list contains some elementContainsStackMatcher
, and simliar.Further now in generation testing we distinguish between symetric and asymmetric test cases. in an asymmetric test case (which was the usual old
TestCase
before refactoring) we fill an index with some context literals (AsymmetricTest::context()
) and then check the result of callingRule::generateClauses(input)
for some input clause (AsymmetricTest::input
).In a symmetric test there is no distinction between context and input. We run a couple of asymmetric tests using every clause in
SymmetricTest::input
asAsymmetricTest::input
and the remaining clauses asAsymmetricTest::context
.