-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds validate task #35
Conversation
6ec9555
to
e719e53
Compare
Very nice addition, this will be very useful. There seems to be an issue if the ref does not exist and does not start with a v or something. (The latest puppet-hiera version is v3.4.1, there is no 6.0.0 version):
|
5688eda
to
1e0b78d
Compare
@ZeroPointEnergy good catch. That was definitely a bug which is now fixed in latest code.
|
If you need a easy way to test this out on this branch do the following: Update the Rakefile temporarily in this branch/repo with:
Then run |
* Adds basic tests for ra10ke * Adds a text based Puppetfile parser module * Adds a monkey patch file for string colors * Adds a new validate task that checks all the refs of all the git urls. * Adds table_print gem for pretty output with validate task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a quick request to address what @bastelfreak noted here: https://github.com/voxpupuli/ra10ke/pull/35/files#r300161439
@dhollinger Everything looks good to me and updated all the newline endings. Any other comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
of all the git urls.