Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tasks #33

Merged
merged 5 commits into from
Jun 8, 2019
Merged

Refactor tasks #33

merged 5 commits into from
Jun 8, 2019

Conversation

ZeroPointEnergy
Copy link
Contributor

@ZeroPointEnergy ZeroPointEnergy commented Jun 3, 2019 •
edited
Loading

There are actually three different things here:

  • The tasks got separated into their own modules similar to how solve already was
  • Added a purge option to the install task
  • Fix the handling of version tags with a leading "v"

Let me know if I should separate them. I had to put them together in the same PR because the move of the taks to the modules would have resulted in conflicts for the purge changes.

bastelfreak
bastelfreak approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will keep this open for a few days in case somebody else wants to review this as well.

@bastelfreak bastelfreak merged commit 1b93ffb into voxpupuli:master Jun 8, 2019
@ZeroPointEnergy ZeroPointEnergy deleted the refactor_tasks branch June 9, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZeroPointEnergy @bastelfreak